diff options
| author |   Bart Van Assche <bart.vanassche@sandisk.com> | 2015-05-18 13:24:17 +0200 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2015-05-18 13:35:55 -0400 |
| commit | a44074f14ba1ea0747ea737026eb929b81993dc3 (patch) | |
| tree | 21b3c79fdde76da6a313d2db265dfd84f163d48b | |
| parent | IB/srp: Fix connection state tracking (diff) | |
| download | linux-dev-a44074f14ba1ea0747ea737026eb929b81993dc3.tar.xz linux-dev-a44074f14ba1ea0747ea737026eb929b81993dc3.zip | |
IB/srp: Fix reconnection failure handling
Although it is possible to let SRP I/O continue if a reconnect
results in a reduction of the number of channels, the current
code does not handle this scenario correctly. Instead of making
the reconnect code more complex, consider this as a reconnection
failure.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Cc: Sebastian Parschauer <sebastian.riemer@profitbricks.com>
Cc: <stable@vger.kernel.org> #v3.19
Signed-off-by: Doug Ledford <dledford@redhat.com>
| -rw-r--r-- | drivers/infiniband/ulp/srp/ib_srp.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index c418d1fde1ed..75c01b27bd0b 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -1243,11 +1243,8 @@ static int srp_rport_reconnect(struct srp_rport *rport) for (i = 0; i < target->ch_count; i++) { ch = &target->ch[i]; - if (ret || !ch->target) { - if (i > 1) - ret = 0; + if (ret || !ch->target) break; - } ret = srp_connect_ch(ch, multich); multich = true; } |