diff options
| author |   Julian Wiedmann <jwi@linux.vnet.ibm.com> | 2018-03-20 07:59:15 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-22 11:52:30 -0400 |
| commit | a6c3d93963e4b333c764fde69802c3ea9eaa9d5c (patch) | |
| tree | 23145fdd088f356787f3c40c8becaf205df29886 | |
| parent | s390/qeth: lock read device while queueing next buffer (diff) | |
| download | linux-dev-a6c3d93963e4b333c764fde69802c3ea9eaa9d5c.tar.xz linux-dev-a6c3d93963e4b333c764fde69802c3ea9eaa9d5c.zip | |
s390/qeth: on channel error, reject further cmd requests
When the IRQ handler determines that one of the cmd IO channels has
failed and schedules recovery, block any further cmd requests from
being submitted. The request would inevitably stall, and prevent the
recovery from making progress until the request times out.
This sort of error was observed after Live Guest Relocation, where
the pending IO on the READ channel intentionally gets terminated to
kick-start recovery. Simultaneously the guest executed SIOCETHTOOL,
triggering qeth to issue a QUERY CARD INFO command. The command
then stalled in the inoperabel WRITE channel.
Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/s390/net/qeth_core_main.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index 2a9afaf8f264..3653bea38470 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -1174,6 +1174,7 @@ static void qeth_irq(struct ccw_device *cdev, unsigned long intparm, } rc = qeth_get_problem(cdev, irb); if (rc) { + card->read_or_write_problem = 1; qeth_clear_ipacmd_list(card); qeth_schedule_recovery(card); goto out; |