diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-05-16 08:58:04 +0200 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2021-05-23 08:52:41 +0800 |
| commit | a6f8e68e238a15bb15f1726b35c695136c64eaba (patch) | |
| tree | 55016b8f25649f25df7c44eed9b0bb0f910e2c8d | |
| parent | crypto: hisilicon/qm - enable to close master ooo when NFE occurs (diff) | |
| download | linux-dev-a6f8e68e238a15bb15f1726b35c695136c64eaba.tar.xz linux-dev-a6f8e68e238a15bb15f1726b35c695136c64eaba.zip | |
crypto: ccp - Fix a resource leak in an error handling path
If an error occurs after calling 'sp_get_irqs()', 'sp_free_irqs()' must be
called as already done in the error handling path.
Fixes: f4d18d656f88 ("crypto: ccp - Abstract interrupt registeration")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: John Allen <john.allen@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | drivers/crypto/ccp/sp-pci.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c index f468594ef8af..6fb6ba35f89d 100644 --- a/drivers/crypto/ccp/sp-pci.c +++ b/drivers/crypto/ccp/sp-pci.c @@ -222,7 +222,7 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) if (ret) { dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n", ret); - goto e_err; + goto free_irqs; } } @@ -230,10 +230,12 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) ret = sp_init(sp); if (ret) - goto e_err; + goto free_irqs; return 0; +free_irqs: + sp_free_irqs(sp); e_err: dev_notice(dev, "initialization failed\n"); return ret; |