diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2018-09-14 17:39:53 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-09-17 07:55:19 -0700 |
| commit | a7f38002fb69b44f8fc622ecb838665d0b8666af (patch) | |
| tree | 268980605e8b77fcc841c6797bf7c3af49e7a7f3 | |
| parent | ARM: dts: at91: add new compatibility string for macb on sama5d3 (diff) | |
| download | linux-dev-a7f38002fb69b44f8fc622ecb838665d0b8666af.tar.xz linux-dev-a7f38002fb69b44f8fc622ecb838665d0b8666af.zip | |
net: hp100: fix always-true check for link up state
The operation ~(p100_inb(VG_LAN_CFG_1) & HP100_LINK_UP) returns a value
that is always non-zero and hence the wait for the link to drop always
terminates prematurely. Fix this by using a logical not operator instead
of a bitwise complement. This issue has been in the driver since
pre-2.6.12-rc2.
Detected by CoverityScan, CID#114157 ("Logical vs. bitwise operator")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/hp/hp100.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/net/ethernet/hp/hp100.c index c8c7ad2eff77..9b5a68b65432 100644 --- a/drivers/net/ethernet/hp/hp100.c +++ b/drivers/net/ethernet/hp/hp100.c @@ -2634,7 +2634,7 @@ static int hp100_login_to_vg_hub(struct net_device *dev, u_short force_relogin) /* Wait for link to drop */ time = jiffies + (HZ / 10); do { - if (~(hp100_inb(VG_LAN_CFG_1) & HP100_LINK_UP_ST)) + if (!(hp100_inb(VG_LAN_CFG_1) & HP100_LINK_UP_ST)) break; if (!in_interrupt()) schedule_timeout_interruptible(1); |