diff options
| author |   Jon Hunter <jonathanh@nvidia.com> | 2022-10-26 16:56:33 +0100 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-10-28 17:27:44 +0100 |
| commit | ae4b3c1252f0fd0951d2f072a02ba46cac8d6c92 (patch) | |
| tree | 042a88df97a61a1c8b3b513c2192381c897fe2c7 | |
| parent | MAINTAINERS: Update HiSilicon SFC Driver maintainer (diff) | |
| download | linux-dev-ae4b3c1252f0fd0951d2f072a02ba46cac8d6c92.tar.xz linux-dev-ae4b3c1252f0fd0951d2f072a02ba46cac8d6c92.zip | |
spi: tegra210-quad: Don't initialise DMA if not supported
The following error messages are observed on boot for Tegra234 ...
ERR KERN tegra-qspi 3270000.spi: cannot use DMA: -19
ERR KERN tegra-qspi 3270000.spi: falling back to PIO
Tegra234 does not support DMA for the QSPI and so initialising the DMA
is expected to fail. The above error messages are misleading for devices
that don't support DMA and so fix this by skipping the DMA
initialisation for devices that don't support DMA.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20221026155633.141792-1-jonathanh@nvidia.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-tegra210-quad.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c index 904972606bd4..10f0c5a6e0dc 100644 --- a/drivers/spi/spi-tegra210-quad.c +++ b/drivers/spi/spi-tegra210-quad.c @@ -720,6 +720,9 @@ static int tegra_qspi_start_cpu_based_transfer(struct tegra_qspi *qspi, struct s static void tegra_qspi_deinit_dma(struct tegra_qspi *tqspi) { + if (!tqspi->soc_data->has_dma) + return; + if (tqspi->tx_dma_buf) { dma_free_coherent(tqspi->dev, tqspi->dma_buf_size, tqspi->tx_dma_buf, tqspi->tx_dma_phys); @@ -750,6 +753,9 @@ static int tegra_qspi_init_dma(struct tegra_qspi *tqspi) u32 *dma_buf; int err; + if (!tqspi->soc_data->has_dma) + return 0; + dma_chan = dma_request_chan(tqspi->dev, "rx"); if (IS_ERR(dma_chan)) { err = PTR_ERR(dma_chan); |