aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMuhammad Usama Anjum <usama.anjum@collabora.com>2022-02-14 23:41:08 +0500
committerDave Hansen <dave.hansen@linux.intel.com>2022-02-17 11:55:17 -0800
commitb06e15ebd5bfb670f93c7f11a29b8299c1178bc6 (patch)
tree18b99a2bf936d26f3213f869eebac4021d69bec4
parentselftests/sgx: Remove extra newlines in test output (diff)
downloadlinux-dev-b06e15ebd5bfb670f93c7f11a29b8299c1178bc6.tar.xz
linux-dev-b06e15ebd5bfb670f93c7f11a29b8299c1178bc6.zip
selftests/x86: Add validity check and allow field splitting
Add check to test if CC has a string. CC can have multiple sub-strings like "ccache gcc". Erorr pops up if it is treated as single string and double quotes are used around it. This can be fixed by removing the quotes and not treating CC as a single string. Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection") Reported-by: "kernelci.org bot" <bot@kernelci.org> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Link: https://lkml.kernel.org/r/20220214184109.3739179-2-usama.anjum@collabora.com
-rwxr-xr-xtools/testing/selftests/x86/check_cc.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh
index 3e2089c8cf54..8c669c0d662e 100755
--- a/tools/testing/selftests/x86/check_cc.sh
+++ b/tools/testing/selftests/x86/check_cc.sh
@@ -7,7 +7,7 @@ CC="$1"
TESTPROG="$2"
shift 2
-if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
+if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
echo 1
else
echo 0