diff options
| author |   Julia Lawall <Julia.Lawall@lip6.fr> | 2014-11-22 15:39:16 +0100 |
|---|---|---|
| committer |   Sebastian Reichel <sre@kernel.org> | 2015-02-28 20:14:13 +0100 |
| commit | b2249129f438799e251fe1e05d0b6f38dc6e63b4 (patch) | |
| tree | 3b35dbfd3090f1b15f55964299c88009048f09af | |
| parent | Linux 4.0-rc1 (diff) | |
| download | linux-dev-b2249129f438799e251fe1e05d0b6f38dc6e63b4.tar.xz linux-dev-b2249129f438799e251fe1e05d0b6f38dc6e63b4.zip | |
HSI: nokia-modem: fix error return code
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
| -rw-r--r-- | drivers/hsi/clients/nokia-modem.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c index eb4dc63dbc93..9be4867fa224 100644 --- a/drivers/hsi/clients/nokia-modem.c +++ b/drivers/hsi/clients/nokia-modem.c @@ -200,6 +200,7 @@ static int nokia_modem_probe(struct device *dev) modem->ssi_protocol = hsi_new_client(port, &ssip); if (!modem->ssi_protocol) { dev_err(dev, "Could not register ssi-protocol device\n"); + err = -ENOMEM; goto error2; } |