aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Deucher <alexander.deucher@amd.com>2020-11-30 17:53:43 -0500
committerAlex Deucher <alexander.deucher@amd.com>2020-12-01 16:04:38 -0500
commitb4339bb9a4f807f0acfbcc89e7abe77f431058c8 (patch)
tree79aff8543cef17cb48ee8436e76e8930b14f594e
parentdrm/amdgpu: enable AGP aperture on gmc10.x (v2) (diff)
downloadlinux-dev-b4339bb9a4f807f0acfbcc89e7abe77f431058c8.tar.xz
linux-dev-b4339bb9a4f807f0acfbcc89e7abe77f431058c8.zip
drm/amdgpu/swsmu/vangogh: return error if fetching metrics fails
rather than just dropping the error. Also fixes a set but not used variable warning. Reviewed-by: Evan Quan <evan.quan@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 1c1af7483dfe..86a1410631fb 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -410,6 +410,8 @@ static int vangogh_get_current_activity_percent(struct smu_context *smu,
ret = vangogh_get_smu_metrics_data(smu,
METRICS_AVERAGE_GFXACTIVITY,
value);
+ if (ret)
+ return ret;
break;
default:
dev_err(smu->adev->dev, "Invalid sensor for retrieving clock activity\n");