diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-04-08 11:22:46 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-04-11 10:45:34 +0100 |
| commit | b559edfaf3f3f3eb726f99f65b181ab310b3d4bc (patch) | |
| tree | 2cb918efdaa83fa9811e02e61d04f6abbca87a7c | |
| parent | Merge branch 'icmp-skb-reason' (diff) | |
| download | linux-dev-b559edfaf3f3f3eb726f99f65b181ab310b3d4bc.tar.xz linux-dev-b559edfaf3f3f3eb726f99f65b181ab310b3d4bc.zip | |
net: ethernet: mtk_eth_soc: fix return value check in mtk_wed_add_hw()
If syscon_regmap_lookup_by_phandle() fails, it never return NULL pointer,
change the check to IS_ERR().
Fixes: 804775dfc288 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_wed.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c index f0eacf819cd9..5d510ac24f2a 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed.c +++ b/drivers/net/ethernet/mediatek/mtk_wed.c @@ -813,7 +813,7 @@ void mtk_wed_add_hw(struct device_node *np, struct mtk_eth *eth, return; regs = syscon_regmap_lookup_by_phandle(np, NULL); - if (!regs) + if (IS_ERR(regs)) return; rcu_assign_pointer(mtk_soc_wed_ops, &wed_ops); |