diff options
| author |   Jean Delvare <khali@linux-fr.org> | 2010-10-24 18:16:59 +0200 |
|---|---|---|
| committer |   Jean Delvare <khali@endymion.delvare> | 2010-10-24 18:16:59 +0200 |
| commit | bf5d95c82692ead9ba7876af73dac2edcc8a6191 (patch) | |
| tree | 546ff11c11534062477bb5ec73c27a98907e5e72 | |
| parent | i2c/pca954x: Remove __devinit and __devexit from probe and remove functions (diff) | |
| download | linux-dev-bf5d95c82692ead9ba7876af73dac2edcc8a6191.tar.xz linux-dev-bf5d95c82692ead9ba7876af73dac2edcc8a6191.zip | |
i2c-viapro: Don't log nacks
Transactions not acked can happen every now and then, in particular
during device detection, and various transaction types can be used for
this purpose. So stop logging this event, except when debugging is
enabled. This is what other similar drivers (e.g. i2c-i801 or
i2c-piix4) do.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
| -rw-r--r-- | drivers/i2c/busses/i2c-viapro.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c index 4c6fff5f330d..0b012f1f8ac5 100644 --- a/drivers/i2c/busses/i2c-viapro.c +++ b/drivers/i2c/busses/i2c-viapro.c @@ -185,14 +185,8 @@ static int vt596_transaction(u8 size) } if (temp & 0x04) { - int read = inb_p(SMBHSTADD) & 0x01; result = -ENXIO; - /* The quick and receive byte commands are used to probe - for chips, so errors are expected, and we don't want - to frighten the user. */ - if (!((size == VT596_QUICK && !read) || - (size == VT596_BYTE && read))) - dev_err(&vt596_adapter.dev, "Transaction error!\n"); + dev_dbg(&vt596_adapter.dev, "No response\n"); } /* Resetting status register */ |