diff options
| author |   Aditya Pakki <pakki001@umn.edu> | 2020-06-13 20:33:42 -0500 |
|---|---|---|
| committer |   Ben Skeggs <bskeggs@redhat.com> | 2020-07-24 18:50:49 +1000 |
| commit | bfad51c7633325b5d4b32444efe04329d53297b2 (patch) | |
| tree | 48ede1ae4547291f83a012c3c21254cfd18677bd | |
| parent | drm/nouveau/sec2/gp102: allow module to load when LSFW is missing (diff) | |
drm/nouveau/drm/noveau: fix reference count leak in nouveau_fbcon_open
nouveau_fbcon_open() calls calls pm_runtime_get_sync() that
increments the reference count. In case of failure, decrement the
ref count before returning the error.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index f9f5a13fdb80..4a93641c33e1 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -189,8 +189,10 @@ nouveau_fbcon_open(struct fb_info *info, int user) struct nouveau_fbdev *fbcon = info->par; struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev); int ret = pm_runtime_get_sync(drm->dev->dev); - if (ret < 0 && ret != -EACCES) + if (ret < 0 && ret != -EACCES) { + pm_runtime_put(drm->dev->dev); return ret; + } return 0; } |