diff options
| author |   James Hogan <jhogan@kernel.org> | 2017-12-05 22:28:22 +0000 |
|---|---|---|
| committer |   Ralf Baechle <ralf@linux-mips.org> | 2018-01-10 16:47:25 +0100 |
| commit | c04de7b1ad645b61c141df8ca903ba0cc03a57f7 (patch) | |
| tree | 0b8734ef873b617605695d7b4a3a3e7c4037f499 | |
| parent | MIPS: ralink: Fix platform_get_irq's error checking (diff) | |
| download | linux-dev-c04de7b1ad645b61c141df8ca903ba0cc03a57f7.tar.xz linux-dev-c04de7b1ad645b61c141df8ca903ba0cc03a57f7.zip | |
MIPS: CM: Drop WARN_ON(vp != 0)
Since commit 68923cdc2eb3 ("MIPS: CM: Add cluster & block args to
mips_cm_lock_other()"), mips_smp_send_ipi_mask() has used
mips_cm_lock_other_cpu() with each CPU number, rather than
mips_cm_lock_other() with the first VPE in each core. Prior to r6,
multicore multithreaded systems such as dual-core dual-thread
interAptivs with CPU Idle enabled (e.g. MIPS Creator Ci40) results in
mips_cm_lock_other() repeatedly hitting WARN_ON(vp != 0).
There doesn't appear to be anything fundamentally wrong about passing a
non-zero VP/VPE number, even if it is a core's region that is locked
into the other region before r6, so remove that particular WARN_ON().
Fixes: 68923cdc2eb3 ("MIPS: CM: Add cluster & block args to mips_cm_lock_other()")
Signed-off-by: James Hogan <jhogan@kernel.org>
Reviewed-by: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@linux-mips.org
Cc: stable@vger.kernel.org # 4.14+
Patchwork: https://patchwork.linux-mips.org/patch/17883/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
| -rw-r--r-- | arch/mips/kernel/mips-cm.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/mips/kernel/mips-cm.c b/arch/mips/kernel/mips-cm.c index dd5567b1e305..8f5bd04f320a 100644 --- a/arch/mips/kernel/mips-cm.c +++ b/arch/mips/kernel/mips-cm.c @@ -292,7 +292,6 @@ void mips_cm_lock_other(unsigned int cluster, unsigned int core, *this_cpu_ptr(&cm_core_lock_flags)); } else { WARN_ON(cluster != 0); - WARN_ON(vp != 0); WARN_ON(block != CM_GCR_Cx_OTHER_BLOCK_LOCAL); /* |