diff options
| author |   Andrew Lunn <andrew@lunn.ch> | 2021-10-24 21:48:02 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-10-25 14:06:43 +0100 |
| commit | c10a485c3de5ccbf1fff65a382cebcb2730c6b06 (patch) | |
| tree | 694033b093dc000bba571f9ff618132d1d2be074 | |
| parent | net: ethernet: microchip: lan743x: Fix dma allocation failure by using dma_set_mask_and_coherent (diff) | |
| download | linux-dev-c10a485c3de5ccbf1fff65a382cebcb2730c6b06.tar.xz linux-dev-c10a485c3de5ccbf1fff65a382cebcb2730c6b06.zip | |
phy: phy_ethtool_ksettings_get: Lock the phy for consistency
The PHY structure should be locked while copying information out if
it, otherwise there is no guarantee of self consistency. Without the
lock the PHY state machine could be updating the structure.
Fixes: 2d55173e71b0 ("phy: add generic function to support ksetting support")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/phy.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index f124a8a58bd4..8457b829667e 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -299,6 +299,7 @@ EXPORT_SYMBOL(phy_ethtool_ksettings_set); void phy_ethtool_ksettings_get(struct phy_device *phydev, struct ethtool_link_ksettings *cmd) { + mutex_lock(&phydev->lock); linkmode_copy(cmd->link_modes.supported, phydev->supported); linkmode_copy(cmd->link_modes.advertising, phydev->advertising); linkmode_copy(cmd->link_modes.lp_advertising, phydev->lp_advertising); @@ -317,6 +318,7 @@ void phy_ethtool_ksettings_get(struct phy_device *phydev, cmd->base.autoneg = phydev->autoneg; cmd->base.eth_tp_mdix_ctrl = phydev->mdix_ctrl; cmd->base.eth_tp_mdix = phydev->mdix; + mutex_unlock(&phydev->lock); } EXPORT_SYMBOL(phy_ethtool_ksettings_get); |