diff options
| author |   Andrew Lunn <andrew@lunn.ch> | 2020-07-05 22:36:25 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-07-05 15:45:38 -0700 |
| commit | c226e2716ee25ab8e6b868559be00a1c30282486 (patch) | |
| tree | 958bb6416b97e780b1086ed93b6b2015b9391bd9 | |
| parent | net: dsa: bcm_sf2: Initialize __be16 with a __be16 value (diff) | |
| download | linux-dev-c226e2716ee25ab8e6b868559be00a1c30282486.tar.xz linux-dev-c226e2716ee25ab8e6b868559be00a1c30282486.zip | |
net: dsa: bcm_sf2: Pass GENMASK() signed bits
Oddly, GENMASK() requires signed bit numbers, so that it can compare
them for < 0. If passed an unsigned type, we get warnings about the
test never being true. There is no danger of overflow here, udf is
always a u8, so there is plenty of space when expanding to an int.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/dsa/bcm_sf2_cfp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/dsa/bcm_sf2_cfp.c b/drivers/net/dsa/bcm_sf2_cfp.c index b54339477853..d82cee5d9202 100644 --- a/drivers/net/dsa/bcm_sf2_cfp.c +++ b/drivers/net/dsa/bcm_sf2_cfp.c @@ -128,12 +128,12 @@ static inline unsigned int bcm_sf2_get_num_udf_slices(const u8 *layout) return count; } -static inline u32 udf_upper_bits(unsigned int num_udf) +static inline u32 udf_upper_bits(int num_udf) { return GENMASK(num_udf - 1, 0) >> (UDFS_PER_SLICE - 1); } -static inline u32 udf_lower_bits(unsigned int num_udf) +static inline u32 udf_lower_bits(int num_udf) { return (u8)GENMASK(num_udf - 1, 0); } |