diff options
| author |   Geordan Neukum <gneukum1@gmail.com> | 2019-05-26 01:18:29 +0000 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-05-30 14:04:26 -0700 |
| commit | c5164e568cd75b70382103b108b5bc0d74e0617c (patch) | |
| tree | 41dffd3f173dd0e16ec1c58102b2bd7e4ff3c0b7 | |
| parent | staging: kpc2000: kpc_i2c: Remove pldev from i2c_device structure (diff) | |
staging: kpc2000: kpc_i2c: Use BIT macro rather than manual bit shifting
The FEATURES_* symbols use bit shifting of the style (1 << k) in order
to assign a certain meaning to the value of inividual bits being set
in the value of a given variable. Instead, use the BIT() macro in
order to improve readability and maintain consistency with the rest
of the kernel.
Signed-off-by: Geordan Neukum <gneukum1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/kpc2000/kpc2000_i2c.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c index b2a9cda05f1b..1d100bb7c548 100644 --- a/drivers/staging/kpc2000/kpc2000_i2c.c +++ b/drivers/staging/kpc2000/kpc2000_i2c.c @@ -116,12 +116,12 @@ struct i2c_device { #define PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_SMBUS 0x9c22 -#define FEATURE_SMBUS_PEC (1 << 0) -#define FEATURE_BLOCK_BUFFER (1 << 1) -#define FEATURE_BLOCK_PROC (1 << 2) -#define FEATURE_I2C_BLOCK_READ (1 << 3) +#define FEATURE_SMBUS_PEC BIT(0) +#define FEATURE_BLOCK_BUFFER BIT(1) +#define FEATURE_BLOCK_PROC BIT(2) +#define FEATURE_I2C_BLOCK_READ BIT(3) /* Not really a feature, but it's convenient to handle it as such */ -#define FEATURE_IDF (1 << 15) +#define FEATURE_IDF BIT(15) // FIXME! #undef inb_p |