diff options
| author |   WeitaoWangoc <WeitaoWang-oc@zhaoxin.com> | 2020-10-27 11:16:20 +0800 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2020-11-07 17:49:57 +0200 |
| commit | c521d7e0ff05257bb9128ab7e68b8e2c084ed361 (patch) | |
| tree | 6954b86169167f2aa27c9e719e99453dd863cef2 | |
| parent | brcmfmac: fix SDIO access for big-endian host (diff) | |
| download | linux-dev-c521d7e0ff05257bb9128ab7e68b8e2c084ed361.tar.xz linux-dev-c521d7e0ff05257bb9128ab7e68b8e2c084ed361.zip | |
rtlwifi: Fix non-canonical address access issues
During realtek USB wireless NIC initialization, it's unexpected
disconnection will cause urb sumbmit fail. On the one hand,
_rtl_usb_cleanup_rx will be called to clean up rx stuff, especially for
rtl_wq. On the other hand, disconnection will cause rtl_usb_disconnect
and _rtl_usb_cleanup_rx to be called. So, rtl_wq will be flush/destroy
twice, which will cause non-canonical address 0xdead000000000122 access
and general protection fault.
Fixed this issue by remove _rtl_usb_cleanup_rx when urb sumbmit fail.
Signed-off-by: WeitaoWangoc <WeitaoWang-oc@zhaoxin.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1603768580-2798-1-git-send-email-WeitaoWang-oc@zhaoxin.com
| -rw-r--r-- | drivers/net/wireless/realtek/rtlwifi/usb.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c index 06e073defad6..d62b87f010c9 100644 --- a/drivers/net/wireless/realtek/rtlwifi/usb.c +++ b/drivers/net/wireless/realtek/rtlwifi/usb.c @@ -731,7 +731,6 @@ static int _rtl_usb_receive(struct ieee80211_hw *hw) err_out: usb_kill_anchored_urbs(&rtlusb->rx_submitted); - _rtl_usb_cleanup_rx(hw); return err; } |