aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrederik Deweerdt <frederik.deweerdt@xprog.eu>2010-09-23 22:19:01 +0200
committerArnaldo Carvalho de Melo <acme@redhat.com>2010-10-04 12:08:37 -0300
commitc569d3326bca6774f6c23f1dc91acad5400b6409 (patch)
treeb0d5af7c01a2082cb187101d1de16103f2446e1f
parentperf tools: Fix build breakage (diff)
downloadlinux-dev-c569d3326bca6774f6c23f1dc91acad5400b6409.tar.xz
linux-dev-c569d3326bca6774f6c23f1dc91acad5400b6409.zip
perf ui hist browser: Fix segfault on 'a' for annotate
There a typo in util/ui/browsers/hists.c that leads to a segfault when you press the 'a' key on a non-resolved symbol (plain hex address). LKML-Reference: <20100923201901.GE31726@gambetta> Signed-off-by: Frederik Deweerdt <frederik.deweerdt@xprog.eu> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/util/ui/browsers/hists.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/ui/browsers/hists.c b/tools/perf/util/ui/browsers/hists.c
index dafdf6775d77..6866aa4c41e0 100644
--- a/tools/perf/util/ui/browsers/hists.c
+++ b/tools/perf/util/ui/browsers/hists.c
@@ -773,7 +773,7 @@ int hists__browse(struct hists *self, const char *helpline, const char *ev_name)
switch (key) {
case 'a':
- if (browser->selection->map == NULL &&
+ if (browser->selection->map == NULL ||
browser->selection->map->dso->annotate_warned)
continue;
goto do_annotate;