diff options
| author |   Lv Ruyi <lv.ruyi@zte.com.cn> | 2022-04-18 10:57:55 +0000 |
|---|---|---|
| committer |   Martin K. Petersen <martin.petersen@oracle.com> | 2022-04-26 09:02:44 -0400 |
| commit | c5acd61dbb32b6bda0f3a354108f2b8dcb788985 (patch) | |
| tree | 6b357e6a5571de4d2f35a476d95c96a1594a9b17 | |
| parent | scsi: qla2xxx: edif: Remove unneeded variable (diff) | |
| download | linux-dev-c5acd61dbb32b6bda0f3a354108f2b8dcb788985.tar.xz linux-dev-c5acd61dbb32b6bda0f3a354108f2b8dcb788985.zip | |
scsi: megaraid: Fix error check return value of register_chrdev()
If major equals 0, register_chrdev() returns an error code when it fails.
This function dynamically allocates a major and returns its number on
success, so we should use "< 0" to check it instead of "!".
Link: https://lore.kernel.org/r/20220418105755.2558828-1-lv.ruyi@zte.com.cn
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/megaraid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index a5d8cee2d510..bf491af9f0d6 100644 --- a/drivers/scsi/megaraid.c +++ b/drivers/scsi/megaraid.c @@ -4607,7 +4607,7 @@ static int __init megaraid_init(void) * major number allocation. */ major = register_chrdev(0, "megadev_legacy", &megadev_fops); - if (!major) { + if (major < 0) { printk(KERN_WARNING "megaraid: failed to register char device\n"); } |