diff options
| author |   Johannes Thumshirn <johannes.thumshirn@wdc.com> | 2022-11-04 07:12:35 -0700 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2022-11-07 14:35:25 +0100 |
| commit | c62f6bec53e63b11112e1ebce6bbaa39ce6f6706 (patch) | |
| tree | 9dd5189d111a2b43d19f54478df717662162efe1 | |
| parent | btrfs: zoned: initialize device's zone info for seeding (diff) | |
| download | linux-dev-c62f6bec53e63b11112e1ebce6bbaa39ce6f6706.tar.xz linux-dev-c62f6bec53e63b11112e1ebce6bbaa39ce6f6706.zip | |
btrfs: zoned: fix locking imbalance on scrub
If we're doing device replace on a zoned filesystem and discover in
scrub_enumerate_chunks() that we don't have to copy the block group it is
unlocked before it gets skipped.
But as the block group hasn't yet been locked before it leads to a locking
imbalance. To fix this simply remove the unlock.
This was uncovered by fstests' testcase btrfs/163.
Fixes: 9283b9e09a6d ("btrfs: remove lock protection for BLOCK_GROUP_FLAG_TO_COPY")
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/scrub.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index b659c67af1e0..196c4c6ed1ed 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -3911,7 +3911,6 @@ int scrub_enumerate_chunks(struct scrub_ctx *sctx, if (sctx->is_dev_replace && btrfs_is_zoned(fs_info)) { if (!test_bit(BLOCK_GROUP_FLAG_TO_COPY, &cache->runtime_flags)) { - spin_unlock(&cache->lock); btrfs_put_block_group(cache); goto skip; } |