diff options
| author |   Alexey Khoroshilov <khoroshilov@ispras.ru> | 2013-12-27 18:18:39 -0300 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-01-07 08:55:58 -0200 |
| commit | cd19f7d3e39b3160595d56bb3e3a2bf4f7f4669c (patch) | |
| tree | 6819e3e9cf6bd615dc64144f366a178b02ee274a | |
| parent | [media] [for,v3.14] sn9c102: fix build dependency (diff) | |
| download | linux-dev-cd19f7d3e39b3160595d56bb3e3a2bf4f7f4669c.tar.xz linux-dev-cd19f7d3e39b3160595d56bb3e3a2bf4f7f4669c.zip | |
[media] as102: fix leaks at failure paths in as102_usb_probe()
Failure handling is incomplete in as102_usb_probe().
The patch implements proper resource deallocations.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
| -rw-r--r-- | drivers/staging/media/as102/as102_usb_drv.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/staging/media/as102/as102_usb_drv.c b/drivers/staging/media/as102/as102_usb_drv.c index 8759553decac..e4a69454ebeb 100644 --- a/drivers/staging/media/as102/as102_usb_drv.c +++ b/drivers/staging/media/as102/as102_usb_drv.c @@ -401,14 +401,21 @@ static int as102_usb_probe(struct usb_interface *intf, /* request buffer allocation for streaming */ ret = as102_alloc_usb_stream_buffer(as102_dev); if (ret != 0) - goto failed; + goto failed_stream; /* register dvb layer */ ret = as102_dvb_register(as102_dev); + if (ret != 0) + goto failed_dvb; return ret; +failed_dvb: + as102_free_usb_stream_buffer(as102_dev); +failed_stream: + usb_deregister_dev(intf, &as102_usb_class_driver); failed: + usb_put_dev(as102_dev->bus_adap.usb_dev); usb_set_intfdata(intf, NULL); kfree(as102_dev); return ret; |