diff options
| author |   wuchi <wuchi.zero@gmail.com> | 2022-06-25 21:53:24 +0800 |
|---|---|---|
| committer |   akpm <akpm@linux-foundation.org> | 2022-07-17 17:31:38 -0700 |
| commit | cda83bb8a61e6d7ce231dc1c2b78a9b79b1f1411 (patch) | |
| tree | bae10768a5ff35e64d7f4247ef1bb9690b81c2d8 | |
| parent | kfifo: fix kfifo_to_user() return type (diff) | |
| download | linux-dev-cda83bb8a61e6d7ce231dc1c2b78a9b79b1f1411.tar.xz linux-dev-cda83bb8a61e6d7ce231dc1c2b78a9b79b1f1411.zip | |
lib/radix-tree: remove unused argument of insert_entries
insert_entries() doesn't use the 'bool replace' argument, and the function
is only used locally, remove the argument.
The historical context of the unused argument is as follow:
2: commit <3a08cd52c37c79> (radix tree: Remove multiorder support)
Remove the code related to macro CONFIG_RADIX_TREE_MULTIORDER
to convert to the xArray.
Without the macro, there is no need to retain the argument.
1: commit <175542f575723e> (radix-tree: add radix_tree_join)
Add insert_entries(..., bool replace) function, depending on the
macro CONFIG_RADIX_TREE_MULTIORDER definition, the implementation
is different. Notice that the implementation without the macro doesn't
use the argument.
[Matthew Wilcox: add historical context for argument]
Link: https://lkml.kernel.org/r/20220625135324.72574-1-wuchi.zero@gmail.com
Signed-off-by: wuchi <wuchi.zero@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
| -rw-r--r-- | lib/radix-tree.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/radix-tree.c b/lib/radix-tree.c index b3afafe46fff..3c78e1e8b2ad 100644 --- a/lib/radix-tree.c +++ b/lib/radix-tree.c @@ -677,7 +677,7 @@ static void radix_tree_free_nodes(struct radix_tree_node *node) } static inline int insert_entries(struct radix_tree_node *node, - void __rcu **slot, void *item, bool replace) + void __rcu **slot, void *item) { if (*slot) return -EEXIST; @@ -711,7 +711,7 @@ int radix_tree_insert(struct radix_tree_root *root, unsigned long index, if (error) return error; - error = insert_entries(node, slot, item, false); + error = insert_entries(node, slot, item); if (error < 0) return error; |