diff options
| author |   Andy Grover <andy.grover@oracle.com> | 2010-04-15 17:19:29 -0700 |
|---|---|---|
| committer | Andy Grover <andy.grover@oracle.com> | 2010-09-08 18:12:25 -0700 |
| commit | ce47f52f42e69d48d1b63fa618fce9cd7ffa9417 (patch) | |
| tree | 6abfde17a22d48b2659ae33e69b69a3349afb749 | |
| parent | RDS: Use a generation counter to avoid rds_send_xmit loop (diff) | |
| download | linux-dev-ce47f52f42e69d48d1b63fa618fce9cd7ffa9417.tar.xz linux-dev-ce47f52f42e69d48d1b63fa618fce9cd7ffa9417.zip | |
RDS: Update comments in rds_send_xmit()
Update comments to reflect changes in previous commit.
Keeping as separate commits due to different authorship.
Signed-off-by: Andy Grover <andy.grover@oracle.com>
| -rw-r--r-- | net/rds/send.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/net/rds/send.c b/net/rds/send.c index 663fd60b40cf..8e3fd9981c2e 100644 --- a/net/rds/send.c +++ b/net/rds/send.c @@ -353,15 +353,14 @@ restart: /* * Other senders will see we have c_send_lock and exit. We * need to recheck the send queue and race again for c_send_lock - * to make sure messages don't just sit on the send queue. + * to make sure messages don't just sit on the send queue, if + * somebody hasn't already beat us into the loop. * * If the transport cannot continue (i.e ret != 0), then it must * call us when more room is available, such as from the tx * completion handler. */ if (ret == 0) { - /* A simple bit test would be way faster than taking the - * spin lock */ smp_mb(); if (!list_empty(&conn->c_send_queue)) { rds_stats_inc(s_send_lock_queue_raced); |