diff options
| author |   Xin Long <lucien.xin@gmail.com> | 2019-12-13 16:53:05 +0800 |
|---|---|---|
| committer |   Pablo Neira Ayuso <pablo@netfilter.org> | 2019-12-17 22:58:25 +0100 |
| commit | cf3e204a1ca5442190018a317d9ec181b4639bd6 (patch) | |
| tree | da11f6479d027c21907fd02a9c33af44b47ce868 | |
| parent | netfilter: Document ingress hook (diff) | |
| download | linux-dev-cf3e204a1ca5442190018a317d9ec181b4639bd6.tar.xz linux-dev-cf3e204a1ca5442190018a317d9ec181b4639bd6.zip | |
netfilter: nft_tunnel: no need to call htons() when dumping ports
info->key.tp_src and tp_dst are __be16, when using nla_put_be16()
to dump them, htons() is not needed, so remove it in this patch.
Fixes: af308b94a2a4 ("netfilter: nf_tables: add tunnel support")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
| -rw-r--r-- | net/netfilter/nft_tunnel.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/netfilter/nft_tunnel.c b/net/netfilter/nft_tunnel.c index 3d4c2ae605a8..ef2065dd4f8a 100644 --- a/net/netfilter/nft_tunnel.c +++ b/net/netfilter/nft_tunnel.c @@ -501,8 +501,8 @@ static int nft_tunnel_opts_dump(struct sk_buff *skb, static int nft_tunnel_ports_dump(struct sk_buff *skb, struct ip_tunnel_info *info) { - if (nla_put_be16(skb, NFTA_TUNNEL_KEY_SPORT, htons(info->key.tp_src)) < 0 || - nla_put_be16(skb, NFTA_TUNNEL_KEY_DPORT, htons(info->key.tp_dst)) < 0) + if (nla_put_be16(skb, NFTA_TUNNEL_KEY_SPORT, info->key.tp_src) < 0 || + nla_put_be16(skb, NFTA_TUNNEL_KEY_DPORT, info->key.tp_dst) < 0) return -1; return 0; |