diff options
| author |   Dan Carpenter <error27@gmail.com> | 2010-07-10 11:51:54 +0200 |
|---|---|---|
| committer |   Eric Van Hensbergen <ericvh@gmail.com> | 2010-08-02 10:37:17 -0500 |
| commit | cff6b8a9b81b404e8ce0257b26007c3afe625212 (patch) | |
| tree | 8d8793de1843a1831f5ee38efb273a30f06c2a65 | |
| parent | virtio_9p.h needs <linux/types.h> (diff) | |
| download | linux-dev-cff6b8a9b81b404e8ce0257b26007c3afe625212.tar.xz linux-dev-cff6b8a9b81b404e8ce0257b26007c3afe625212.zip | |
9p: strlen() doesn't count the terminator
This is an off by one bug because strlen() doesn't count the NULL
terminator. We strcpy() addr into a fixed length array of size
UNIX_PATH_MAX later on.
The addr variable is the name of the device being mounted.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
| -rw-r--r-- | net/9p/trans_fd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index 98ce9bcb0e15..c85109d809ca 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c @@ -948,7 +948,7 @@ p9_fd_create_unix(struct p9_client *client, const char *addr, char *args) csocket = NULL; - if (strlen(addr) > UNIX_PATH_MAX) { + if (strlen(addr) >= UNIX_PATH_MAX) { P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n", addr); return -ENAMETOOLONG; |