diff options
| author |   Kangjie Lu <kangjielu@gmail.com> | 2016-05-03 21:36:11 -0400 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-05-03 22:57:14 -0700 |
| commit | d13829686bba3e06e2217f044beb8fd5a9abf792 (patch) | |
| tree | 60446786b7e0d74e1c175623319c0e507ba41dfd | |
| parent | staging: comedi: mite: tidy up module init/exit (diff) | |
| download | linux-dev-d13829686bba3e06e2217f044beb8fd5a9abf792.tar.xz linux-dev-d13829686bba3e06e2217f044beb8fd5a9abf792.zip | |
staging: wilc1000: fix infoleak in wilc_wfi_cfgoperations
"mac" is an array allocated in stack without being initialized,
and will be sent out via "nla_put". The dump_station() is supposed
to initialize the mac address; otherwise, sensitive data in kernel
stack will be leaked. To fix this, copy the mac address to it.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index 85031f75d7ee..4b041356f823 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -1804,6 +1804,7 @@ static int dump_station(struct wiphy *wiphy, struct net_device *dev, wilc_get_rssi(vif, &sinfo->signal); + memcpy(mac, priv->au8AssociatedBss, ETH_ALEN); return 0; } |