diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2012-07-10 20:32:51 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2012-07-12 07:54:45 -0700 |
| commit | d348446b8840602091872b8272855dee196f6dd5 (patch) | |
| tree | 52822f855dd80de30de0dc2f1c7f26d109dfa00c | |
| parent | net: add support for NS8390 based eth controllers on some ColdFire CPU boards (diff) | |
| download | linux-dev-d348446b8840602091872b8272855dee196f6dd5.tar.xz linux-dev-d348446b8840602091872b8272855dee196f6dd5.zip | |
smsc95xx: signedness bug in get_regs()
"retval" has to be a signed integer for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/smsc95xx.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 05ecf14d6597..bd7cbaa688e4 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -589,7 +589,8 @@ smsc95xx_ethtool_getregs(struct net_device *netdev, struct ethtool_regs *regs, void *buf) { struct usbnet *dev = netdev_priv(netdev); - unsigned int i, j, retval; + unsigned int i, j; + int retval; u32 *data = buf; retval = smsc95xx_read_reg(dev, ID_REV, ®s->version); |