aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTang Bin <tangbin@cmss.chinamobile.com>2020-05-28 19:47:17 +0800
committerFelipe Balbi <balbi@kernel.org>2020-06-24 09:43:16 +0300
commitd410912ef63714fad404f34baa72e5ceb0466e62 (patch)
tree2a5dbda6e7dcedf39c15a63e5d5ffa327b3f626f
parentusb: dwc3: pci: Fix reference count leak in dwc3_pci_resume_work (diff)
downloadlinux-dev-d410912ef63714fad404f34baa72e5ceb0466e62.tar.xz
linux-dev-d410912ef63714fad404f34baa72e5ceb0466e62.zip
usb: phy: tegra: Fix unnecessary check in tegra_usb_phy_probe()
In the function tegra_usb_phy_probe(), if usb_add_phy_dev() failed, the return value will be given to err, and if usb_add_phy_dev() succeed, the return value will be zero. Thus it is unnecessary to repeated check here. Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Signed-off-by: Felipe Balbi <balbi@kernel.org>
-rw-r--r--drivers/usb/phy/phy-tegra-usb.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
index cffe2aced488..03a333797382 100644
--- a/drivers/usb/phy/phy-tegra-usb.c
+++ b/drivers/usb/phy/phy-tegra-usb.c
@@ -1199,11 +1199,7 @@ static int tegra_usb_phy_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, tegra_phy);
- err = usb_add_phy_dev(&tegra_phy->u_phy);
- if (err)
- return err;
-
- return 0;
+ return usb_add_phy_dev(&tegra_phy->u_phy);
}
static int tegra_usb_phy_remove(struct platform_device *pdev)