diff options
| author |   Geert Uytterhoeven <geert+renesas@glider.be> | 2019-07-31 15:29:17 +0200 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2019-08-05 13:31:17 +0200 |
| commit | d55b7fdd58ac12e76ef65979af4a13b9c15fc00d (patch) | |
| tree | 8f05534bc9fd51cccd6f569b1dc07d17228297cc | |
| parent | pinctrl: lantiq: Use kasprintf() instead of fixed buffer formatting (diff) | |
| download | linux-dev-d55b7fdd58ac12e76ef65979af4a13b9c15fc00d.tar.xz linux-dev-d55b7fdd58ac12e76ef65979af4a13b9c15fc00d.zip | |
pinctrl: xway: Use devm_kasprintf() instead of fixed buffer formatting
Improve readability and maintainability by replacing a hardcoded string
allocation and formatting by the use of the devm_kasprintf() helper.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20190731132917.17607-4-geert+renesas@glider.be
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/pinctrl/pinctrl-xway.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl/pinctrl-xway.c index 376222d0e5c5..913d38f29b73 100644 --- a/drivers/pinctrl/pinctrl-xway.c +++ b/drivers/pinctrl/pinctrl-xway.c @@ -1731,13 +1731,11 @@ static int pinmux_xway_probe(struct platform_device *pdev) return -ENOMEM; for (i = 0; i < xway_chip.ngpio; i++) { - /* strlen("ioXY") + 1 = 5 */ - char *name = devm_kzalloc(&pdev->dev, 5, GFP_KERNEL); + char *name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "io%d", i); if (!name) return -ENOMEM; - snprintf(name, 5, "io%d", i); xway_info.pads[i].number = GPIO0 + i; xway_info.pads[i].name = name; } |