diff options
| author |   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2016-03-23 00:44:40 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-03-23 13:38:40 -0400 |
| commit | d57019d1858a6f9b3ca05d76d793466ae428cfa3 (patch) | |
| tree | 7cb05bdd7a96563abd7b9fdc6f30a285a8da1c77 | |
| parent | Merge branch 'AF_VSOCK-missed-wakeups' (diff) | |
| download | linux-dev-d57019d1858a6f9b3ca05d76d793466ae428cfa3.tar.xz linux-dev-d57019d1858a6f9b3ca05d76d793466ae428cfa3.zip | |
at803x: fix reset handling
The driver of course "knows" that the chip's reset signal is active low,
so it drives the GPIO to 0 to reset the PHY and to 1 otherwise; however
all this will only work iff the GPIO is specified as active-high in the
device tree! I think both the driver and the device trees (if there are
any -- I was unable to find them) need to be fixed in this case...
Fixes: 13a56b449325 ("net: phy: at803x: Add support for hardware reset")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/at803x.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 1e901c7cfaac..d7f03fa4ba8f 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -277,7 +277,7 @@ static int at803x_probe(struct phy_device *phydev) if (!priv) return -ENOMEM; - gpiod_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); + gpiod_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(gpiod_reset)) return PTR_ERR(gpiod_reset); @@ -362,10 +362,10 @@ static void at803x_link_change_notify(struct phy_device *phydev) at803x_context_save(phydev, &context); - gpiod_set_value(priv->gpiod_reset, 0); - msleep(1); gpiod_set_value(priv->gpiod_reset, 1); msleep(1); + gpiod_set_value(priv->gpiod_reset, 0); + msleep(1); at803x_context_restore(phydev, &context); |