diff options
| author |   Hangyu Hua <hbh25y@gmail.com> | 2022-03-02 10:19:59 +0800 |
|---|---|---|
| committer |   Michael Ellerman <mpe@ellerman.id.au> | 2022-03-08 22:07:41 +1100 |
| commit | d601fd24e6964967f115f036a840f4f28488f63f (patch) | |
| tree | 953ba129dedf8f0729262d9f12666547e3092d43 | |
| parent | powerpc/64e: Tie PPC_BOOK3E_64 to PPC_FSL_BOOK3E (diff) | |
| download | linux-dev-d601fd24e6964967f115f036a840f4f28488f63f.tar.xz linux-dev-d601fd24e6964967f115f036a840f4f28488f63f.zip | |
powerpc/secvar: fix refcount leak in format_show()
Refcount leak will happen when format_show returns failure in multiple
cases. Unified management of of_node_put can fix this problem.
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220302021959.10959-1-hbh25y@gmail.com
| -rw-r--r-- | arch/powerpc/kernel/secvar-sysfs.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c index a0a78aba2083..1ee4640a2641 100644 --- a/arch/powerpc/kernel/secvar-sysfs.c +++ b/arch/powerpc/kernel/secvar-sysfs.c @@ -26,15 +26,18 @@ static ssize_t format_show(struct kobject *kobj, struct kobj_attribute *attr, const char *format; node = of_find_compatible_node(NULL, NULL, "ibm,secvar-backend"); - if (!of_device_is_available(node)) - return -ENODEV; + if (!of_device_is_available(node)) { + rc = -ENODEV; + goto out; + } rc = of_property_read_string(node, "format", &format); if (rc) - return rc; + goto out; rc = sprintf(buf, "%s\n", format); +out: of_node_put(node); return rc; |