diff options
| author |   Peng Li <lipeng321@huawei.com> | 2021-06-11 11:36:18 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-11 12:58:11 -0700 |
| commit | d72f78db55d6daa4542668de1b2cb4f974708a99 (patch) | |
| tree | 95ada6083855067d6d7aa12796e5c5b3c706cbc0 | |
| parent | net: pc300too: fix the code style issue about "foo * bar" (diff) | |
net: pc300too: move out assignment in if condition
Should not use assignment in if condition.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/wan/pc300too.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/wan/pc300too.c b/drivers/net/wan/pc300too.c index 17d5cb8287d4..7d8eae5ea140 100644 --- a/drivers/net/wan/pc300too.c +++ b/drivers/net/wan/pc300too.c @@ -349,12 +349,14 @@ static int pc300_pci_init_one(struct pci_dev *pdev, else card->n_ports = 2; - for (i = 0; i < card->n_ports; i++) - if (!(card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]))) { + for (i = 0; i < card->n_ports; i++) { + card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]); + if (!card->ports[i].netdev) { pr_err("unable to allocate memory\n"); pc300_pci_remove_one(pdev); return -ENOMEM; } + } /* Reset PLX */ p = &card->plxbase->init_ctrl; |