diff options
| author |   Eric Sesterhenn <snakebyte@gmx.de> | 2006-06-21 16:10:48 +0200 |
|---|---|---|
| committer |   Jeff Garzik <jeff@garzik.org> | 2006-06-22 23:22:17 -0400 |
| commit | da4f5ccf6040b998b64c60db8fa5f4ee03fdaf95 (patch) | |
| tree | f150dbaf402cc48baca720749135ff47987ff87e | |
| parent | [PATCH] 8139cp: add ethtool eeprom support (diff) | |
| download | linux-dev-da4f5ccf6040b998b64c60db8fa5f4ee03fdaf95.tar.xz linux-dev-da4f5ccf6040b998b64c60db8fa5f4ee03fdaf95.zip | |
[PATCH] Remove useless check in drivers/net/pcmcia/xirc2ps_cs.c
hi,
coverity choked at this check (id #223), assuming that
skb might be NULL and used anyways later. Since
start_hard_xmit() always gets called with a valid
skb, the check is useless and this patch removes it.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| -rw-r--r-- | drivers/net/pcmcia/xirc2ps_cs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/pcmcia/xirc2ps_cs.c b/drivers/net/pcmcia/xirc2ps_cs.c index 71f45056a70c..e80d1e3aec68 100644 --- a/drivers/net/pcmcia/xirc2ps_cs.c +++ b/drivers/net/pcmcia/xirc2ps_cs.c @@ -1359,7 +1359,7 @@ do_start_xmit(struct sk_buff *skb, struct net_device *dev) kio_addr_t ioaddr = dev->base_addr; int okay; unsigned freespace; - unsigned pktlen = skb? skb->len : 0; + unsigned pktlen = skb->len; DEBUG(1, "do_start_xmit(skb=%p, dev=%p) len=%u\n", skb, dev, pktlen); |