aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2012-09-20 21:13:55 +0000
committerDavid S. Miller <davem@davemloft.net>2012-09-21 13:47:24 -0400
commitdc9c9759ebc65d886453c335b2b5be39f87ab01e (patch)
treee22f582f886455db89bcd9023e0bbdff8b7945f1
parentstmmac: fix return value check in stmmac_open_ext_timer() (diff)
downloadlinux-dev-dc9c9759ebc65d886453c335b2b5be39f87ab01e.tar.xz
linux-dev-dc9c9759ebc65d886453c335b2b5be39f87ab01e.zip
net/irda: sh_sir: fix return value check in sh_sir_set_baudrate()
In case of error, the function clk_get() returns ERR_PTR() and never returns NULL pointer. The NULL test in the error handling should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/irda/sh_sir.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c
index 256eddf1f75a..795109425568 100644
--- a/drivers/net/irda/sh_sir.c
+++ b/drivers/net/irda/sh_sir.c
@@ -280,7 +280,7 @@ static int sh_sir_set_baudrate(struct sh_sir_self *self, u32 baudrate)
}
clk = clk_get(NULL, "irda_clk");
- if (!clk) {
+ if (IS_ERR(clk)) {
dev_err(dev, "can not get irda_clk\n");
return -EIO;
}