diff options
| author |   Mark Brown <broonie@kernel.org> | 2016-04-20 10:16:36 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-05-01 14:04:19 -0700 |
| commit | dd69a18ae71070ffd8805fcdfed6404762eaffa2 (patch) | |
| tree | d81e3f854ef90f55181f3bc280d7f6a6f63f4485 | |
| parent | eeprom: at25: Fix SPI device leak (diff) | |
| download | linux-dev-dd69a18ae71070ffd8805fcdfed6404762eaffa2.tar.xz linux-dev-dd69a18ae71070ffd8805fcdfed6404762eaffa2.zip | |
eeprom: 93xx46: Fix SPI device leak
The 93xx46 driver is using spi_dev_get() apparently just to take a copy
of the SPI device used to instantiate it but never calls spi_dev_put()
to free it. Since the device is guaranteed to exist between probe() and
remove() there should be no need for the driver to take an extra
reference to it so fix the leak by just using a straight assignment.
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/misc/eeprom/eeprom_93xx46.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c index 5004d72c9f42..94cc035aa841 100644 --- a/drivers/misc/eeprom/eeprom_93xx46.c +++ b/drivers/misc/eeprom/eeprom_93xx46.c @@ -465,7 +465,7 @@ static int eeprom_93xx46_probe(struct spi_device *spi) mutex_init(&edev->lock); - edev->spi = spi_dev_get(spi); + edev->spi = spi; edev->pdata = pd; edev->size = 128; |