diff options
| author |   Thomas Meyer <thomas@m3y3r.de> | 2011-12-02 12:35:43 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2011-12-04 01:32:06 -0500 |
| commit | ddf98e6d30a966dbd6e675c90e2caa5b9486e519 (patch) | |
| tree | 65b3c690bcbbe1a500b835b6776e0d895effe392 | |
| parent | enic: Use kcalloc instead of kzalloc to allocate array (diff) | |
| download | linux-dev-ddf98e6d30a966dbd6e675c90e2caa5b9486e519.tar.xz linux-dev-ddf98e6d30a966dbd6e675c90e2caa5b9486e519.zip | |
ll_temac: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/xilinx/ll_temac_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 282330d9801b..903a77b416df 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -237,7 +237,7 @@ static int temac_dma_bd_init(struct net_device *ndev) struct sk_buff *skb; int i; - lp->rx_skb = kzalloc(sizeof(*lp->rx_skb) * RX_BD_NUM, GFP_KERNEL); + lp->rx_skb = kcalloc(RX_BD_NUM, sizeof(*lp->rx_skb), GFP_KERNEL); if (!lp->rx_skb) { dev_err(&ndev->dev, "can't allocate memory for DMA RX buffer\n"); |