diff options
| author |   Julia Lawall <julia@diku.dk> | 2009-01-09 10:22:53 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2009-01-11 00:06:34 -0800 |
| commit | debc251b602fa4795c00c0aa82caa28cebc619ee (patch) | |
| tree | 007b9ebe28ac16ecc1914ffbb089745e9b88428e | |
| parent | net/bridge/netfilter: move a dereference below a NULL test (diff) | |
| download | linux-dev-debc251b602fa4795c00c0aa82caa28cebc619ee.tar.xz linux-dev-debc251b602fa4795c00c0aa82caa28cebc619ee.zip | |
drivers/isdn/hardware/mISDN: move a dereference below a NULL test
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/isdn/hardware/mISDN/hfcmulti.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c index 97f4708b3879..595ba8eb4a07 100644 --- a/drivers/isdn/hardware/mISDN/hfcmulti.c +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c @@ -3615,7 +3615,7 @@ hfcm_bctrl(struct mISDNchannel *ch, u_int cmd, void *arg) static void ph_state_change(struct dchannel *dch) { - struct hfc_multi *hc = dch->hw; + struct hfc_multi *hc; int ch, i; if (!dch) { @@ -3623,6 +3623,7 @@ ph_state_change(struct dchannel *dch) __func__); return; } + hc = dch->hw; ch = dch->slot; if (hc->type == 1) { |