diff options
| author |   Christoph Hellwig <hch@lst.de> | 2017-05-22 10:40:52 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2017-06-20 11:12:57 +0200 |
| commit | e0c7a510aea75db4927d810fb0a84233641b53c3 (patch) | |
| tree | 2ca46b813bc2455fe4826a8441a7d24df7a44c9c | |
| parent | dmaengine: ioat: don't use DMA_ERROR_CODE (diff) | |
| download | linux-dev-e0c7a510aea75db4927d810fb0a84233641b53c3.tar.xz linux-dev-e0c7a510aea75db4927d810fb0a84233641b53c3.zip | |
drm/exynos: don't use DMA_ERROR_CODE
DMA_ERROR_CODE already isn't a valid API to user for drivers and will
go away soon. exynos_drm_fb_dma_addr uses it a an error return when
the passed in index is invalid, but the callers never check for it
but instead pass the address straight to the hardware.
Add a WARN_ON instead and just return 0.
Signed-off-by: Christoph Hellwig <hch@lst.de>
| -rw-r--r-- | drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index c77a5aced81a..d48fd7c918f8 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c @@ -181,8 +181,8 @@ dma_addr_t exynos_drm_fb_dma_addr(struct drm_framebuffer *fb, int index) { struct exynos_drm_fb *exynos_fb = to_exynos_fb(fb); - if (index >= MAX_FB_BUFFER) - return DMA_ERROR_CODE; + if (WARN_ON_ONCE(index >= MAX_FB_BUFFER)) + return 0; return exynos_fb->dma_addr[index]; } |