diff options
| author |   Kan Liang <kan.liang@linux.intel.com> | 2021-08-26 08:32:38 -0700 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2021-08-31 13:59:35 +0200 |
| commit | e2bb9fab08cbcc7922050c7eb0bd650807abfa4e (patch) | |
| tree | 224eb68c22c075ba3e712035eae47d58cf9d50b6 | |
| parent | perf/x86/intel/uncore: Support extra IMC channel on Ice Lake server (diff) | |
| download | linux-dev-e2bb9fab08cbcc7922050c7eb0bd650807abfa4e.tar.xz linux-dev-e2bb9fab08cbcc7922050c7eb0bd650807abfa4e.zip | |
perf/x86/intel/uncore: Fix invalid unit check
The uncore unit with the type ID 0 and the unit ID 0 is missed.
The table3 of the uncore unit maybe 0. The
uncore_discovery_invalid_unit() mistakenly treated it as an invalid
value.
Remove the !unit.table3 check.
Fixes: edae1f06c2cd ("perf/x86/intel/uncore: Parse uncore discovery tables")
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/1629991963-102621-3-git-send-email-kan.liang@linux.intel.com
| -rw-r--r-- | arch/x86/events/intel/uncore_discovery.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/events/intel/uncore_discovery.h b/arch/x86/events/intel/uncore_discovery.h index 7280c8a3c831..6d735611c281 100644 --- a/arch/x86/events/intel/uncore_discovery.h +++ b/arch/x86/events/intel/uncore_discovery.h @@ -30,7 +30,7 @@ #define uncore_discovery_invalid_unit(unit) \ - (!unit.table1 || !unit.ctl || !unit.table3 || \ + (!unit.table1 || !unit.ctl || \ unit.table1 == -1ULL || unit.ctl == -1ULL || \ unit.table3 == -1ULL) |