diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-11-11 08:45:44 +0100 |
|---|---|---|
| committer |   Konstantin Komarov <almaz.alexandrovich@paragon-software.com> | 2021-11-23 18:03:47 +0300 |
| commit | e589f9b7078e1c0191613cd736f598e81d2390de (patch) | |
| tree | fe02d8d0fd08544dadc2f18776015e8c7d27ca52 | |
| parent | Linux 5.15 (diff) | |
| download | linux-dev-e589f9b7078e1c0191613cd736f598e81d2390de.tar.xz linux-dev-e589f9b7078e1c0191613cd736f598e81d2390de.zip | |
fs/ntfs3: Fix some memory leaks in an error handling path of 'log_replay()'
All error handling paths lead to 'out' where many resources are freed.
Do it as well here instead of a direct return, otherwise 'log', 'ra' and
'log->one_page_buf' (at least) will leak.
Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
| -rw-r--r-- | fs/ntfs3/fslog.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c index 06492f088d60..915f42cf07bc 100644 --- a/fs/ntfs3/fslog.c +++ b/fs/ntfs3/fslog.c @@ -4085,8 +4085,10 @@ process_log: if (client == LFS_NO_CLIENT_LE) { /* Insert "NTFS" client LogFile. */ client = ra->client_idx[0]; - if (client == LFS_NO_CLIENT_LE) - return -EINVAL; + if (client == LFS_NO_CLIENT_LE) { + err = -EINVAL; + goto out; + } t16 = le16_to_cpu(client); cr = ca + t16; |