diff options
| author |   Sergey Shtylyov <s.shtylyov@omp.ru> | 2022-01-29 14:55:17 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-01-31 11:42:13 +0000 |
| commit | e7d966f9ea52c4c77491646068dbd5412a6225b4 (patch) | |
| tree | cd83d2520cd19b990d921b503c900c63a022e048 | |
| parent | ravb: ravb_close() always returns 0 (diff) | |
| download | linux-dev-e7d966f9ea52c4c77491646068dbd5412a6225b4.tar.xz linux-dev-e7d966f9ea52c4c77491646068dbd5412a6225b4.zip | |
sh_eth: sh_eth_close() always returns 0
sh_eth_close() always returns 0, hence the check in sh_eth_wol_restore()
is pointless (however we cannot change the prototype of sh_eth_close() as
it implements the driver's ndo_stop() method).
Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/renesas/sh_eth.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 8aa91e99227d..9ff6089905d6 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -3444,9 +3444,7 @@ static int sh_eth_wol_restore(struct net_device *ndev) * both be reset and all registers restored. This is what * happens during suspend and resume without WoL enabled. */ - ret = sh_eth_close(ndev); - if (ret < 0) - return ret; + sh_eth_close(ndev); ret = sh_eth_open(ndev); if (ret < 0) return ret; |