diff options
| author |   Miaoqian Lin <linmq006@gmail.com> | 2022-06-01 12:09:28 +0400 |
|---|---|---|
| committer |   Marc Zyngier <maz@kernel.org> | 2022-06-09 17:36:57 +0100 |
| commit | ec8401a429ffee34ccf38cebf3443f8d5ae6cb0d (patch) | |
| tree | 600bef033ecfb0f51972c1b678cf4a84d4ae54c4 | |
| parent | irqchip/apple-aic: Fix refcount leak in aic_of_ic_init (diff) | |
| download | linux-dev-ec8401a429ffee34ccf38cebf3443f8d5ae6cb0d.tar.xz linux-dev-ec8401a429ffee34ccf38cebf3443f8d5ae6cb0d.zip | |
irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
When kcalloc fails, it missing of_node_put() and results in refcount
leak. Fix this by goto out_put_node label.
Fixes: 52085d3f2028 ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-5-linmq006@gmail.com
| -rw-r--r-- | drivers/irqchip/irq-gic-v3.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 2be8dea6b6b0..1d5b4755a27e 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -1932,7 +1932,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL); if (!gic_data.ppi_descs) - return; + goto out_put_node; nr_parts = of_get_child_count(parts_node); |