diff options
| author |   Vytas Dauksa <vytas.dauksa@smoothwall.net> | 2014-04-04 16:10:14 +0100 |
|---|---|---|
| committer |   Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> | 2014-08-24 19:31:34 +0200 |
| commit | ecc245c2bd5dcee91e6818fd3e7fb6454ad2ca06 (patch) | |
| tree | 0f373fc99f0b3789beb100ec8dbfc7fee2d50f18 | |
| parent | netfilter: nft_meta: Add cpu attribute support (diff) | |
| download | linux-dev-ecc245c2bd5dcee91e6818fd3e7fb6454ad2ca06.tar.xz linux-dev-ecc245c2bd5dcee91e6818fd3e7fb6454ad2ca06.zip | |
netfilter: ipset: Removed invalid IPSET_ATTR_MARKMASK validation
Markmask is an u32, hence it can't be greater then 4294967295 ( i.e.
0xffffffff ). This was causing smatch warning:
net/netfilter/ipset/ip_set_hash_gen.h:1084 hash_ipmark_create() warn:
impossible condition '(markmask > 4294967295) => (0-u32max > u32max)'
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
| -rw-r--r-- | net/netfilter/ipset/ip_set_hash_gen.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/ipset/ip_set_hash_gen.h b/net/netfilter/ipset/ip_set_hash_gen.h index 61c7fb052802..0398a92da6cc 100644 --- a/net/netfilter/ipset/ip_set_hash_gen.h +++ b/net/netfilter/ipset/ip_set_hash_gen.h @@ -1093,7 +1093,7 @@ IPSET_TOKEN(HTYPE, _create)(struct net *net, struct ip_set *set, if (tb[IPSET_ATTR_MARKMASK]) { markmask = ntohl(nla_get_u32(tb[IPSET_ATTR_MARKMASK])); - if ((markmask > 4294967295u) || markmask == 0) + if (markmask == 0) return -IPSET_ERR_INVALID_MARKMASK; } #endif |