diff options
| author |   Xiubo Li <xiubli@redhat.com> | 2021-11-30 19:20:34 +0800 |
|---|---|---|
| committer |   Ilya Dryomov <idryomov@gmail.com> | 2021-12-01 17:08:26 +0100 |
| commit | ee2a095d3b24f300a5e11944d208801e928f108c (patch) | |
| tree | c951a6f0c6455352ccdaecd3d78f3ff37172417d | |
| parent | ceph: initialize i_size variable in ceph_sync_read (diff) | |
| download | linux-dev-ee2a095d3b24f300a5e11944d208801e928f108c.tar.xz linux-dev-ee2a095d3b24f300a5e11944d208801e928f108c.zip | |
ceph: initialize pathlen variable in reconnect_caps_cb
The smatch static checker warned about an uninitialized symbol usage in
this function, in the case where ceph_mdsc_build_path returns an error.
It turns out that that case is harmless, but it just looks sketchy.
Initialize the variable at declaration time, and remove the unneeded
setting of it later.
Fixes: a33f6432b3a6 ("ceph: encode inodes' parent/d_name in cap reconnect message")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
| -rw-r--r-- | fs/ceph/mds_client.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index 250aad330a10..c30eefc0ac19 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -3683,7 +3683,7 @@ static int reconnect_caps_cb(struct inode *inode, struct ceph_cap *cap, struct ceph_pagelist *pagelist = recon_state->pagelist; struct dentry *dentry; char *path; - int pathlen, err; + int pathlen = 0, err; u64 pathbase; u64 snap_follows; @@ -3703,7 +3703,6 @@ static int reconnect_caps_cb(struct inode *inode, struct ceph_cap *cap, } } else { path = NULL; - pathlen = 0; pathbase = 0; } |