diff options
| author |   Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-02-22 15:11:20 +0100 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-02-23 10:54:29 +0100 |
| commit | ee3c7795e54f405fbd278b17d2e0cd8ca1c92b69 (patch) | |
| tree | 4825b0897afd682e1aaaf53473294c9f978dccff | |
| parent | drm/irq: Don't call ->get_vblank_counter directly from irq_uninstall/cleanup (diff) | |
| download | linux-dev-ee3c7795e54f405fbd278b17d2e0cd8ca1c92b69.tar.xz linux-dev-ee3c7795e54f405fbd278b17d2e0cd8ca1c92b69.zip | |
drm: WARN if drm_handle_vblank is called errornously
KMS drivers are in full control of their irq and vblank handling, if
they get a vblank interrupt before drm_vblank_init or after
drm_vblank_cleanup that's just a driver bug.
For ums driver there's only r128 and radeon which support vblank, and
they call drm_vblank_init in their driver load functions. Which again
means that userspace can do whatever it wants with interrupt, vblank
structures will always be there.
So this should never happen, let's catch driver issues with a WARN_ON.
Motivated by some discussions with Imre.
v2: Use WARN_ON_ONCE as suggested by Imre.
Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
| -rw-r--r-- | drivers/gpu/drm/drm_irq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 4bb7d34ff79e..65a45ce70e2a 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -1682,7 +1682,7 @@ bool drm_handle_vblank(struct drm_device *dev, int crtc) struct timeval tvblank; unsigned long irqflags; - if (!dev->num_crtcs) + if (WARN_ON_ONCE(!dev->num_crtcs)) return false; if (WARN_ON(crtc >= dev->num_crtcs)) |