diff options
| author |   Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-05 10:52:23 -0600 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-01-07 11:42:08 -0500 |
| commit | f87d8ad9233f115db92c6c087d58403b0009ed36 (patch) | |
| tree | cc30dc603aa2816f59110627eb9c95724a9fc6a3 | |
| parent | cdc_ether: trivial whitespace readability fix (diff) | |
| download | linux-dev-f87d8ad9233f115db92c6c087d58403b0009ed36.tar.xz linux-dev-f87d8ad9233f115db92c6c087d58403b0009ed36.zip | |
tipc: fix memory leak in tipc_nl_compat_publ_dump
There is a memory leak in case genlmsg_put fails.
Fix this by freeing *args* before return.
Addresses-Coverity-ID: 1476406 ("Resource leak")
Fixes: 46273cf7e009 ("tipc: fix a missing check of genlmsg_put")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/tipc/netlink_compat.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 40f5cae623a7..77e4b2418f30 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -904,8 +904,10 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock) hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI, TIPC_NL_PUBL_GET); - if (!hdr) + if (!hdr) { + kfree_skb(args); return -EMSGSIZE; + } nest = nla_nest_start(args, TIPC_NLA_SOCK); if (!nest) { |