aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJia-Ju Bai <baijiaju1990@gmail.com>2021-03-04 05:19:57 -0800
committerJiri Kosina <jkosina@suse.cz>2021-03-08 11:33:49 +0100
commitfa8ba6e5dc0e78e409e503ddcfceef5dd96527f4 (patch)
tree5bd2e2b2949df7ceb9f4d479febfc48d8c0a398d
parentHID: asus: Add support for 2021 ASUS N-Key keyboard (diff)
downloadlinux-dev-fa8ba6e5dc0e78e409e503ddcfceef5dd96527f4.tar.xz
linux-dev-fa8ba6e5dc0e78e409e503ddcfceef5dd96527f4.zip
HID: alps: fix error return code in alps_input_configured()
When input_register_device() fails, no error return code is assigned. To fix this bug, ret is assigned with -ENOENT as error return code. Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/hid-alps.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index 3feaece13ade..6b665931147d 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -761,6 +761,7 @@ static int alps_input_configured(struct hid_device *hdev, struct hid_input *hi)
if (input_register_device(data->input2)) {
input_free_device(input2);
+ ret = -ENOENT;
goto exit;
}
}