diff options
| author |   Peng Li <lipeng321@huawei.com> | 2019-01-31 04:55:43 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-01-30 14:50:03 -0800 |
| commit | fc0c174f4223b7340999e1b3004dbc3b3b9b06de (patch) | |
| tree | 21e2b46c92c89f383810192bf5c5dc201f2d57a1 | |
| parent | net: hns3: fix VF dump register issue (diff) | |
| download | linux-dev-fc0c174f4223b7340999e1b3004dbc3b3b9b06de.tar.xz linux-dev-fc0c174f4223b7340999e1b3004dbc3b3b9b06de.zip | |
net: hns3: use the correct interface to stop|open port
dev_close() stop the netdev and the service base on the netdev
will stop. But ndev->netdev_ops->ndo_stop() may only stop HW
and stack queue, the service base on the netdev can still work.
Fixes: 5668abda0931 ("net: hns3: add support for set_ringparam")
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c index 76ef06a7c261..63f5f56bda94 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c @@ -805,7 +805,7 @@ static int hns3_set_ringparam(struct net_device *ndev, old_desc_num, new_desc_num); if (if_running) - dev_close(ndev); + ndev->netdev_ops->ndo_stop(ndev); ret = hns3_uninit_all_ring(priv); if (ret) @@ -822,7 +822,7 @@ static int hns3_set_ringparam(struct net_device *ndev, } if (if_running) - ret = dev_open(ndev, NULL); + ret = ndev->netdev_ops->ndo_open(ndev); return ret; } |