diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2021-11-16 14:49:16 +0300 |
|---|---|---|
| committer |   John Harrison <John.C.Harrison@Intel.com> | 2021-11-16 12:07:48 -0800 |
| commit | fc12b70d12d07598cde27cc17dbfafc2a2a33ff8 (patch) | |
| tree | 1e5ac4f0ef3d0ee18f216d1f521672a5acff82f7 | |
| parent | drm/i915: Skip error capture when wedged on init (diff) | |
| download | linux-dev-fc12b70d12d07598cde27cc17dbfafc2a2a33ff8.tar.xz linux-dev-fc12b70d12d07598cde27cc17dbfafc2a2a33ff8.zip | |
drm/i915/guc: fix NULL vs IS_ERR() checking
The intel_engine_create_virtual() function does not return NULL. It
returns error pointers.
Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211116114916.GB11936@kili
| -rw-r--r-- | drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c index d7e49f7c1dba..77fbcd8730ee 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c @@ -3354,8 +3354,8 @@ guc_create_parallel(struct intel_engine_cs **engines, ce = intel_engine_create_virtual(siblings, num_siblings, FORCE_VIRTUAL); - if (!ce) { - err = ERR_PTR(-ENOMEM); + if (IS_ERR(ce)) { + err = ERR_CAST(ce); goto unwind; } |