diff options
| author |   Masakazu Mokuno <mokuno@sm.sony.co.jp> | 2007-08-29 20:30:25 +0900 |
|---|---|---|
| committer |   Paul Mackerras <paulus@samba.org> | 2007-08-30 20:49:41 +1000 |
| commit | fc43dca9e75b87d24a16d5be7b497e83837d9d31 (patch) | |
| tree | 0c46f32f4c4ad7c1446215dfb8e6eee5a2e46039 | |
| parent | [POWERPC] Update defconfigs (diff) | |
| download | linux-dev-fc43dca9e75b87d24a16d5be7b497e83837d9d31.tar.xz linux-dev-fc43dca9e75b87d24a16d5be7b497e83837d9d31.zip | |
[POWERPC] PS3: Fix bug where the major version part is not compared
Fix the bug that the major version part of the firmware version number
is ignored in the comparison done by ps3_compare_firmware_version
because the difference of two 64-bit quantities is returned as an int.
Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
| -rw-r--r-- | arch/powerpc/platforms/ps3/setup.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/powerpc/platforms/ps3/setup.c b/arch/powerpc/platforms/ps3/setup.c index 2952b22f1c84..609945dbe394 100644 --- a/arch/powerpc/platforms/ps3/setup.c +++ b/arch/powerpc/platforms/ps3/setup.c @@ -63,7 +63,8 @@ int ps3_compare_firmware_version(u16 major, u16 minor, u16 rev) x.minor = minor; x.rev = rev; - return (ps3_firmware_version.raw - x.raw); + return (ps3_firmware_version.raw > x.raw) - + (ps3_firmware_version.raw < x.raw); } EXPORT_SYMBOL_GPL(ps3_compare_firmware_version); |