diff options
| author |   Stefan Weil <weil@mail.berlios.de> | 2011-01-31 20:56:54 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2011-01-31 20:56:54 -0800 |
| commit | fca540ab5f4718c6133f71f7be1793066008bf89 (patch) | |
| tree | 4993fcd3b9011a9d2a5f57bd85180baef7e9060f | |
| parent | net: Fix ipv6 neighbour unregister_sysctl_table warning (diff) | |
| download | linux-dev-fca540ab5f4718c6133f71f7be1793066008bf89.tar.xz linux-dev-fca540ab5f4718c6133f71f7be1793066008bf89.zip | |
enc28j60: Fix reading of transmit status vector
This error was reported by cppcheck:
drivers/net/enc28j60.c:815: error: Using sizeof for array given as function argument returns the size of pointer.
The original code reads 4 or 8 bytes instead of TSV_SIZE (= 100) bytes.
I just fixed the code, but did not run any tests.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/enc28j60.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/enc28j60.c b/drivers/net/enc28j60.c index 112c5aa9af7f..907b05a1c659 100644 --- a/drivers/net/enc28j60.c +++ b/drivers/net/enc28j60.c @@ -812,7 +812,7 @@ static void enc28j60_read_tsv(struct enc28j60_net *priv, u8 tsv[TSV_SIZE]) if (netif_msg_hw(priv)) printk(KERN_DEBUG DRV_NAME ": reading TSV at addr:0x%04x\n", endptr + 1); - enc28j60_mem_read(priv, endptr + 1, sizeof(tsv), tsv); + enc28j60_mem_read(priv, endptr + 1, TSV_SIZE, tsv); } static void enc28j60_dump_tsv(struct enc28j60_net *priv, const char *msg, |